mattermost-community / mattermost-plugin-bitbucket

Mattermost plugin for Bitbucket

Apache License 2.0

6 stars 16 forks source link

Release v1.1.1 #49

Closed hanzei closed 2 years ago

hanzei commented 2 years ago

Summary

Release for Marketplace

[x] Requires https://github.com/mattermost/mattermost-plugin-bitbucket/pull/45 to be merged first

Ticket Link

Part of https://github.com/mattermost/mattermost-plugin-bitbucket/issues/46

hanzei commented 2 years ago

@jfrerich Good catch. Opened https://github.com/mattermost/mattermost-plugin-bitbucket/pull/50 for that.

hanzei commented 2 years ago

@DHaussermann This is release is review for review

codecov-commenter commented 2 years ago

Codecov Report

Merging #49 (1e079b5) into master (1676e74) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   16.18%   16.18%           
=======================================
  Files          13       13           
  Lines        1853     1853           
=======================================
  Hits          300      300           
  Misses       1534     1534           
  Partials       19       19

Impacted Files	Coverage Δ
server/manifest.go	`100.00% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1676e74...1e079b5. Read the comment docs.

DHaussermann commented 2 years ago

/update-branch

hanzei commented 2 years ago

@DHaussermann This release is ready for review

hanzei commented 2 years ago

/update-branch

hanzei commented 2 years ago

@DHaussermann The release is ready for review

DHaussermann commented 2 years ago

/update-branch

DHaussermann commented 2 years ago

@aaronrothschild The code changes added since the initial release test have now been tested and passed.

After doing a quick smoke test there are 2 previously undocumented issues. In my judgment, these would not block the v1.1.1 release. Please advise. If we're satisfied with solving theses in a future release - we can cut this and move on to the marketplace.

https://github.com/mattermost/mattermost-plugin-bitbucket/issues/73 https://github.com/mattermost/mattermost-plugin-bitbucket/issues/72

aaronrothschild commented 2 years ago

Yes, let's fix thiose in a future release, let's cut it! :). 🎉