Closed sibasankarnayak closed 2 years ago
Hello @sibasankarnayak,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
Merging #53 (ed45a69) into master (a7e177d) will not change coverage. The diff coverage is
0.00%
.
@@ Coverage Diff @@
## master #53 +/- ##
=======================================
Coverage 17.03% 17.03%
=======================================
Files 13 13
Lines 1773 1773
=======================================
Hits 302 302
Misses 1453 1453
Partials 18 18
Impacted Files | Coverage Δ | |
---|---|---|
server/api.go | 7.10% <0.00%> (ø) |
|
server/plugin.go | 3.52% <ø> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a7e177d...ed45a69. Read the comment docs.
@dipak-demansol This is the same solution as https://github.com/mattermost/mattermost-plugin-github/pull/511. Hence, I'm incident to merge this PR with QA review once you approved https://github.com/mattermost/mattermost-plugin-github/pull/511. Does that sound good to you?
@dipak-demansol This is the same solution as mattermost/mattermost-plugin-github#511. Hence, I'm incident to merge this PR with QA review once you approved mattermost/mattermost-plugin-github#511. Does that sound good to you?
yes sir.
@dipak-demansol This is the same solution as mattermost/mattermost-plugin-github#511. Hence, I'm incident to merge this PR with QA review once you approved mattermost/mattermost-plugin-github#511. Does that sound good to you?
@hanzei After GitHub PR merge, you can also merge this PR, will add the test cases for this & GitHub PR in the zypher and will do the the testing for both at the time of release or Regression.
fixed the logic of complete the oauth complete redirect
Fixes #52