search

mattermost-community / mattermost-plugin-bitbucket

Mattermost plugin for Bitbucket
Apache License 2.0
6 stars 16 forks source link

Use mattermost-server/v6 #60

Closed hanzei closed 2 years ago

hanzei commented 2 years ago

Summary

This PR updates the dependency on github.com/mattermost/mattermost-server from v5 to v6. This ensures the v6 breaking changes propagate quickly to developers using this plugin.

Please note that the plugin still works against v5 servers.

Ticket Link

None

mickmister commented 2 years ago

We need to bump the min_server_version to 5.37, similar to https://github.com/mattermost/mattermost-marketplace/pull/233

mickmister commented 2 years ago

Our conclusive plan after the incompatibility issue was that we would always import from a specific Mattermost version (not commit, though I see in this PR we are importing using a version), and set the min_server_version to that version. We haven't been following it, but that is what we arrived at to make sure we don't run into similar incombatibility issues in the future.

hanzei commented 2 years ago

@mickmister Thanks for spotting that. Fixed :+1:

codecov-commenter commented 2 years ago

Codecov Report

Merging #60 (d869016) into master (2f9e612) will decrease coverage by 0.04%. The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
- Coverage   17.03%   16.98%   -0.05%     
==========================================
  Files          13       13              
  Lines        1773     1772       -1     
==========================================
- Hits          302      301       -1     
  Misses       1453     1453              
  Partials       18       18
Impacted Files Coverage Δ
server/api.go 6.97% <ø> (-0.13%) :arrow_down:
server/command.go 9.72% <ø> (ø)
server/main.go 0.00% <ø> (ø)
server/plugin.go 3.51% <0.00%> (-0.02%) :arrow_down:
server/webhook.go 0.00% <ø> (ø)
server/utils.go 18.18% <25.00%> (ø)
server/manifest.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2f9e612...d869016. Read the comment docs.

hanzei commented 2 years ago

@sibasankarnayak Gentle reminder to review the PR

DHaussermann commented 2 years ago

@hanzei, @dipak-demansol and I have completed the round of release testing for v1.1.1 Any thoughts on if this required for 1.1.1 as the milestone is set here?

hanzei commented 2 years ago

@DHaussermann No, this PR isn't required for v1.1.1, but given that its low risk, I'm incident to merge it anyway.

hanzei commented 2 years ago

@mickmister Gentle reminder to review the PR

hanzei commented 2 years ago

I'm going to skip QA review as this PR contains mostly tooling changes.