Closed sibasankarnayak closed 1 year ago
Hello @sibasankarnayak,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
@dipak-demansol Can you start the QA in mean time to crosscheck if i had covered all the logical cases.
@sibasankarnayak i'll start working on after you Complete the changes as per mickmister Comment.
dit subscriptions in channels they are not a member of, the current behavior is fine.
@sibasankarnayak Can you please remove the changes pertaining to attaching subscription to its creator? It was determined in #28 that this new behavior is undesired.
As long as "regular" users cannot see or edit subscriptions in channels they are not a member of, the current behavior is fine.
@mickmister Sure, have seperated the code for issue #28
@dipak-demansol you can start testing
@sibasankarnayak :- #67 :- LGTM :- #72 :- LGTM :- #73 :- LGTM :- #68 :- have minor issue, issue link https://drive.google.com/file/d/1A68jP9Ig-6xjP8ejMfBxY2SBNCKDFQFx/view?usp=sharing
@dipak-demansol can you retest once more , fixed the logic
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
Merging #75 (ba1bf81) into master (806f094) will increase coverage by
0.07%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## master #75 +/- ##
==========================================
+ Coverage 16.18% 16.26% +0.07%
==========================================
Files 13 13
Lines 1853 1844 -9
==========================================
Hits 300 300
+ Misses 1534 1525 -9
Partials 19 19
Impacted Files | Coverage Δ | |
---|---|---|
server/command.go | 7.11% <0.00%> (+0.32%) |
:arrow_up: |
server/subscriptions.go | 14.17% <0.00%> (-0.35%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 806f094...ba1bf81. Read the comment docs.
@mickmister @jfrerich Can we merge this PR? (After resolving the conflicts)
@hanzei, I don't see why we wouldn't.
Can we merge this PR? (After resolving the conflicts)
@hanzei This PR was submitted by Demansol. I'm not sure if we're able to update the PR with the conflict resolutions
made some improvements in logic for subscription
Ticket Here Fixes #67 Fixes #68 Fixes #72 Fixes #73