fix issues with validations, error handling and using correct bot user

mattermost-community / mattermost-plugin-google-drive

Google Drive plugin for Mattermost

Apache License 2.0

1 stars 2 forks source link

fix issues with validations, error handling and using correct bot user #10

Closed darkLord19 closed 3 months ago

darkLord19 commented 3 months ago

If account is already disconnected or connected then return relevant message
If user has already enabled or disabled activity notifications then send relevant messages
Send file upload confirmation messages as plugin bot user instead of system user

darkLord19 commented 3 months ago

@fmartingr addressed comments.

wiggin77 commented 3 months ago

Looks great @darkLord19 . There spots in the code where the integration is referred in user facing messages as "Drive". Shouldn't this be "Google Drive"?

darkLord19 commented 3 months ago

@wiggin77 yes making it Google Drive would be more self explanatory I think. Also should I rename the plugin bot user to google-drive because right now it's only drive. I wasnt sure what are the usual naming conventions for bot users.

darkLord19 commented 3 months ago

@wiggin77 @fmartingr can someone merge this PR? I am not getting the option to merge. I will raise separate PR to change the name of bot user and replace Drive with Google Drive in applicable places.

fmartingr commented 3 months ago

@wiggin77 @fmartingr can someone merge this PR? I am not getting the option to merge. I will raise separate PR to change the name of bot user and replace Drive with Google Drive in applicable places.

Done 👍