search

mattermost-community / mattermost-plugin-jitsi

Jitsi plugin for Mattermost :electric_plug:
Apache License 2.0
197 stars 90 forks source link

Add info to admin UI that Embed Jitsi video inside Mattermost and Jitsi Meeting Names do not restrict behavior #124

Closed DHaussermann closed 4 years ago

DHaussermann commented 4 years ago

The admin UI could be a bit more clear that setting an option for Embed Jitsi video inside Mattermost and Jitsi Meeting Names is only adjusting preset options for new users. Some admins could get the impression that these options are disabling or restricting the behavior of the plugin.

0/5 This feels a bit subjective. Maybe to others it's obvious that you're only manipulating the presets. But adding something like Default configuration in the UI may be worth doing.

jespino commented 4 years ago

@jasonblais do you mind to take a look to this?

jasonblais commented 4 years ago

How's https://github.com/mattermost/mattermost-plugin-jitsi/pull/125 @DHaussermann and @jespino?

jespino commented 4 years ago

@jasonblais LGTM :)

DHaussermann commented 4 years ago

Looks good to me as well @jasonblais

Side note - Can you please grant me permissions to manage labels in this repo so I can keep them current.

jasonblais commented 4 years ago

@jespino can you help with permissions for Dylan?

jespino commented 4 years ago

@DHaussermann can you try now, I added you as maintainer of the repo, I think should grant you permissions for that.

DHaussermann commented 4 years ago

Thanks @jespino that solved it 👍