mattermost-community / mattermost-plugin-jitsi

Jitsi plugin for Mattermost :electric_plug:
Apache License 2.0
197 stars 90 forks source link

When setting to small window in mattermost, SENT video quality gets reduced #129

Closed mzealey closed 4 years ago

mzealey commented 4 years ago

Mattermost Version - latest docker images

Plugin Version - 2.0.0

Describe the issue

When using jitsi from within mattermost in the full screen overlay, quality gets SENT at ~1024x550, when i shrink to using the corner overlay the SENT drops to ~300x200. I believe this is a bug and the send quality should stay the same but perhaps the receive quality should get lowered.

jespino commented 4 years ago

Yes, totally agree, the intention was to reduce the receive video quality instead of the sent video quality, I'll take a look into this and I think we can create a 2.0.1 release for that. Thanks for the feedback.

jespino commented 4 years ago

Now I see it, the video quality for receive/sent is set in the same call in the Jitsi external API, so is not possible to set the input video quality without setting the output video quality to the same value (from the external API perspective) I think the most sensible approach is to remove that change, and talk with Jitsi people to see if they can split that in the API or any other solution.

jespino commented 4 years ago

This is now fixed on master.

mzealey commented 4 years ago

thanks, I have raised an issue in jitsi repository above