search

mattermost-community / mattermost-plugin-jitsi

Jitsi plugin for Mattermost :electric_plug:
Apache License 2.0
197 stars 90 forks source link

Mobile URL handling #140

Closed jeff-mccoy closed 2 years ago

jeff-mccoy commented 4 years ago

This is a good improvement, really appreciate the work on it. Before I have my team start doing work on this, has anyone looked at Jitsi URL registration handling? I know on iOS it's just org.jitsi.meet:// vs https:// to open directly in the Jitsi app.

jasonblais commented 4 years ago

@jespino / @aaronrothschild on above

jasonblais commented 4 years ago

Thanks @jeff-mccoy flagging this and for your interest to work on this plugin :)

jespino commented 4 years ago

@jeff-mccoy really cool improvement, that works on android too. My concern is about handling it with other clients (for example text based clients, or after the plugin is disabled). We can mitigate that registering the protocol in the desktop app, and probably adding a config flag to enable/disable this feature. This is only going to be part of the slack attachment alternative view, not the regular post view, so is not going to affect the webapp/desktop app while the plugin is loaded.

jeff-mccoy commented 4 years ago

That seems reasonable, we have a little over 50k users across a few different Mattermost instances with Jitsi deployed in K8s per-env, so we can generate plenty of test data for this as well.

jespino commented 4 years ago

@jeff-mccoy great, feel free to send a PR with a initial proposal and we can iterate over that.

larkox commented 3 years ago

Hi @jeff-mccoy ! Have you looked into this? Are you planning to send a PR?

If you are not able, please let me know, so I can make this a help wanted ticket. :smile: