search

mattermost-community / mattermost-plugin-jitsi

Jitsi plugin for Mattermost :electric_plug:
Apache License 2.0
197 stars 90 forks source link

GH-154: Fix Linting issue with Replace and ReplaceAll #155

Closed tw-ayush closed 4 years ago

tw-ayush commented 4 years ago

The branch had go-linter issues with use of strings.Replace method with replace count -1 and suggested to use ReplaceAll(...) method instead.

https://github.com/mattermost/mattermost-plugin-jitsi/issues/154

codecov-commenter commented 4 years ago

Codecov Report

Merging #155 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #155   +/-   ##
=======================================
  Coverage   41.31%   41.31%           
=======================================
  Files           7        7           
  Lines         789      789           
=======================================
  Hits          326      326           
  Misses        442      442           
  Partials       21       21
Impacted Files Coverage Δ
server/command.go 60.71% <100.00%> (ø)
server/plugin.go 52.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e0951fb...673dd0a. Read the comment docs.

hanzei commented 4 years ago

This can be merged without QA review