search

mattermost-community / mattermost-plugin-jitsi

Jitsi plugin for Mattermost :electric_plug:
Apache License 2.0
195 stars 90 forks source link

#160 Meeting announcement created from ephemeral to get posted in RHS #173

Closed tw-ayush closed 2 years ago

tw-ayush commented 3 years ago

Command responses don't get posted in the RHS #153 Added meeting if from Context (request) to the startMeeting

tw-ayush commented 3 years ago

Hey is there a way to add test for ServeHTTP methods that is already implemented in the repo??

larkox commented 3 years ago

Hi @tw-ayush , I am not sure how this change the behaviour to add the meeting in the right place. Care to explain?

Regarding adding tests, feel free to open a PR to add the tests needed, or just add them in this PR if you think they are relevant to this change.

tw-ayush commented 3 years ago

Hi @tw-ayush , I am not sure how this change the behaviour to add the meeting in the right place. Care to explain?

Regarding adding tests, feel free to open a PR to add the tests needed, or just add them in this PR if you think they are relevant to this change.

hey apologies for the incorrect code earlier, this Issue has been a bit of a confusing pease of work for me. Check if the changes are correct now.

larkox commented 3 years ago

The idea is good, but you need to somehow add the information in the StartMeetingFromAction structure. Probably the best place is to add the rootID to the context of the actions declared in "askMeetingType".

tw-ayush commented 3 years ago

The idea is good, but you need to somehow add the information in the StartMeetingFromAction structure. Probably the best place is to add the rootID to the context of the actions declared in "askMeetingType".

I've added this change in the PR, do i also need to add this in request from someplace in the Repo ??

larkox commented 3 years ago

I'm not sure what you mean. Could you please elaborate?

tw-ayush commented 3 years ago

I'm not sure what you mean. Could you please elaborate?

I've used the RootId from request context but haven't made any changes in the code base to add it there. Is there anyplace where i need to add this rootId in request data?

larkox commented 3 years ago

You would need to add the rootid in server/plugin.go, in the function askMeetingType, in the context of every action that needs it (I think all of them).

tw-ayush commented 3 years ago

You would need to add the rootid in server/plugin.go, in the function askMeetingType, in the context of every action that needs it (I think all of them).

that's already been done in another ticket.

larkox commented 3 years ago

@tw-ayush Are you still working on this?

tw-ayush commented 3 years ago

@tw-ayush Are you still working on this?

this was pending for merge.. Changes are there. Or maybe i'm missing the context here..

hanzei commented 2 years ago

@dipak-demansol Could you please review this PR?