search

mattermost-community / mattermost-plugin-jitsi

Jitsi plugin for Mattermost :electric_plug:
Apache License 2.0
197 stars 90 forks source link

Gh 151 #194

Closed maisnamrajusingh closed 3 years ago

maisnamrajusingh commented 3 years ago

Summary

Adds telemetry tracking on meeting create

Ticket Link

https://github.com/mattermost/mattermost-plugin-jitsi/issues/151

codecov-commenter commented 3 years ago

Codecov Report

Merging #194 (2e87147) into master (b874cc9) will increase coverage by 0.51%. The diff coverage is 46.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #194      +/-   ##
==========================================
+ Coverage   44.95%   45.47%   +0.51%     
==========================================
  Files           7        7              
  Lines         803      873      +70     
==========================================
+ Hits          361      397      +36     
- Misses        417      451      +34     
  Partials       25       25
Impacted Files Coverage Δ
server/configuration.go 16.66% <15.38%> (+2.38%) :arrow_up:
server/plugin.go 61.78% <75.00%> (+0.36%) :arrow_up:
server/command.go 60.49% <100.00%> (+0.40%) :arrow_up:
server/api.go 0.00% <0.00%> (ø)
server/main.go 0.00% <0.00%> (ø)
server/manifest.go 100.00% <0.00%> (ø)
server/randomNameGenerator.go 70.58% <0.00%> (+6.58%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b874cc9...2e87147. Read the comment docs.

jasonblais commented 3 years ago

@maisnamrajusingh is this ready for final review from @hanzei?

maisnamrajusingh commented 3 years ago

@jasonblais there is a doubt that I have mentioned here. https://github.com/mattermost/mattermost-plugin-jitsi/pull/194#discussion_r657897429

jasonblais commented 3 years ago

Got it, thanks! FYI @hanzei

maisnamrajusingh commented 3 years ago

@hanzei it's ready for review. Let me know if it makes sense now. I am using boolean variables to determine if a meeting link is the default one or not based on the caller earlier.