search

mattermost-community / mattermost-plugin-jitsi

Jitsi plugin for Mattermost :electric_plug:
Apache License 2.0
195 stars 90 forks source link

mm-131 - ability to close the jitsi window in embedded mode #196

Closed maisnamrajusingh closed 3 years ago

maisnamrajusingh commented 3 years ago

Summary

Pressing the escape button will close the active meeting window. I have tested this on the web app. I think it may not work on the desktop app. Maybe we can create a separate PR for that if needed.

Ticket Link

https://github.com/mattermost/mattermost-plugin-jitsi/issues/131

codecov-commenter commented 3 years ago

Codecov Report

Merging #196 (3abeff6) into master (b874cc9) will increase coverage by 0.49%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
+ Coverage   44.95%   45.45%   +0.49%     
==========================================
  Files           7        7              
  Lines         803      847      +44     
==========================================
+ Hits          361      385      +24     
- Misses        417      437      +20     
  Partials       25       25
Impacted Files Coverage Δ
server/plugin.go 61.30% <0.00%> (-0.12%) :arrow_down:
server/api.go 0.00% <0.00%> (ø)
server/main.go 0.00% <0.00%> (ø)
server/manifest.go 100.00% <0.00%> (ø)
server/command.go 60.33% <0.00%> (+0.24%) :arrow_up:
server/configuration.go 17.07% <0.00%> (+2.78%) :arrow_up:
server/randomNameGenerator.go 70.58% <0.00%> (+6.58%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b874cc9...3abeff6. Read the comment docs.

larkox commented 3 years ago

@DHaussermann heads up that this has been merged expecting testing during release testing.