mattermost-community / mattermost-plugin-jitsi

Jitsi plugin for Mattermost :electric_plug:

Apache License 2.0

193 stars 89 forks source link

[GH-198] Use Mattermost Username as display name in jitsi #205

Closed hanzei closed 2 years ago

hanzei commented 2 years ago

Summary

Use the Mattermost Username as default display name in Jitsi. Given that the user needs to confirm the display in the loby, there is no need for a setting.

Ticket Link

Fixes https://github.com/mattermost/mattermost-plugin-jitsi/issues/198

codecov-commenter commented 2 years ago

Codecov Report

Merging #205 (b797a7b) into master (558c303) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #205   +/-   ##
=======================================
  Coverage   45.47%   45.47%           
=======================================
  Files           7        7           
  Lines         873      873           
=======================================
  Hits          397      397           
  Misses        451      451           
  Partials       25       25

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 558c303...b797a7b. Read the comment docs.

hanzei commented 2 years ago

@dipak-demansol This PR is ready for your review

dipak-demansol commented 2 years ago

@hanzei tw-ayush:160 issue is also fixed in this PR, what should we do now?

hanzei commented 2 years ago

https://github.com/mattermost/mattermost-plugin-jitsi/pull/173 is not part of part of this PR

dipak-demansol commented 2 years ago

@hanzei i found 3 issue But now its not reproduced, After merge this PR i like to test it again, For now its LGTM.

1) remove the jitsi/disable the plugin then change the mattermost user name then install the jitsi build of this PR or enable the plugin then start the new meeting and join and you will see the old name, after refresh the page you can see the updated name in the jitsi.

2) using 2 different mattermost server, 1 contain market build and 2nd have this PR build then start call from server1 then start call from server 2 and you can see the server2 jitsi call have server1 mattermost users name.

dipak-demansol commented 2 years ago

Tested with the Master Branch, LGTM.