mattermost-community / mattermost-plugin-jitsi

Jitsi plugin for Mattermost :electric_plug:
Apache License 2.0
195 stars 90 forks source link

[GH-170] Allow to overwrite pre join page inside Mattermost #217

Closed raghavaggarwal2308 closed 7 months ago

raghavaggarwal2308 commented 2 years ago

Summary

Added radio buttons in system console settings to disable/enable the pre-join page in Jitsi meet when opened in minimized view.

  1. Added field in plugin.json file to add "Show pre-join page" radio buttons.
  2. OverWrite the Jitsi server config to disable/enable pre-join page.
    configOverwrite: {
    // Disable the pre-join page
    prejoinPageEnabled: this.props.meetingEmbedded && this.props.showPrejoinPage
    }
  3. When the pre-join page is enabled in minimized view, vertical height of the window is increased to avoid croping of the user's profile image.
  4. Fixed govet fieldalignment errors.

Screenshots

  1. When pre-join page is disabled Screenshot from 2022-07-01 15-23-25

  2. When pre-join page is enabled with_bigger_window(updated behaviour)

Ticket

Fixes #170

raghavaggarwal2308 commented 2 years ago

@mickmister Gentle reminder for review

raghavaggarwal2308 commented 2 years ago

@mickmister Gentle reminder for review

raghavaggarwal2308 commented 2 years ago

@mickmister Gentle reminder for review

raghavaggarwal2308 commented 2 years ago

@mickmister Gentle reminder for review

raghavaggarwal2308 commented 1 year ago

@mickmister Gentle reminder for re-review

raghavaggarwal2308 commented 1 year ago

@mickmister Gentle reminder for re-review

mickmister commented 1 year ago

@raghavaggarwal2308 It doesn't look like there have been any changes since I approved the PR. What would you like me to review?

raghavaggarwal2308 commented 1 year ago

@mickmister I meant the review of the answers to the questions you asked when you last reviewed.

mickmister commented 1 year ago

@raghavaggarwal2308 I don't see answers to the questions either though

raghavaggarwal2308 commented 1 year ago

@mickmister Sorry about that, you should be able to see them now

mickmister commented 1 year ago

Ok looks good. For future reference, mentioning me in the comments is good enough if you want to continue discussion on those individual threads. No need to ping with re-review requests if I have "approved" the PR. Hopefully that makes sense.

If the PR is only waiting on QA review, the person you want to reach out to is @DHaussermann

mickmister commented 1 year ago

@raghavaggarwal2308 Sorry if I seem aggressive in my previous comment. It's just a little frustrating to see this sit here like this. I'm sure it's more frustrating for you as well, sorry about this.

raghavaggarwal2308 commented 1 year ago

@mickmister No issues, I understand :)

DHaussermann commented 1 year ago

/update-branch

raghavaggarwal2308 commented 1 year ago

@DHaussermann Gentle reminder for review

raghavaggarwal2308 commented 1 year ago

@DHaussermann Gentle reminder for review

raghavaggarwal2308 commented 1 year ago

@DHaussermann Gentle reminder for review

raghavaggarwal2308 commented 1 year ago

@DHaussermann Gentle reminder for review

raghavaggarwal2308 commented 1 year ago

@DHaussermann Gentle reminder for review

raghavaggarwal2308 commented 1 year ago

@DHaussermann Gentle reminder for review

raghavaggarwal2308 commented 1 year ago

@DHaussermann Gentle reminder for review

raghavaggarwal2308 commented 1 year ago

@DHaussermann Gentle reminder for review