search

mattermost-community / mattermost-plugin-jitsi

Jitsi plugin for Mattermost :electric_plug:
Apache License 2.0
200 stars 90 forks source link

Use ReactDOM webpack external #224

Closed mickmister closed 2 years ago

mickmister commented 2 years ago

Summary

This plugin currently doesn't use react-dom or react-select, so nothing should have broken here. One of these libraries may be used in the future.

Ticket Link

Fixes https://mattermost.atlassian.net/browse/MM-47046

codecov-commenter commented 2 years ago

Codecov Report

Base: 45.47% // Head: 45.47% // No change to project coverage :thumbsup:

Coverage data is based on head (5bc57ac) compared to base (e09c61d). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #224 +/- ## ======================================= Coverage 45.47% 45.47% ======================================= Files 7 7 Lines 873 873 ======================================= Hits 397 397 Misses 451 451 Partials 25 25 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.