search

mattermost-community / mattermost-plugin-solar-lottery

A tool somewhat similar to pager duty, allows to have rotations with magic "solar lottery" scheduling, or overrides.
Apache License 2.0
4 stars 10 forks source link

Task refactor #23

Closed levb closed 4 years ago

levb commented 4 years ago

Summary

Draft PR, need to write up the summary - many changes. The biggest is the addition of Tasks (tickets or shifts) and a significant refactoring. A lot of functional tests are now automated with commands. This PR is still missing Autopilot, Guess, and Forecast capabilities to be at parity with the previous status quo, as well as many details.

WIP - will edit later.

@iomodo @larkox - master has been reviewed by @crspeller and @cpoile, but they now moved on. I think the 2 of you are probably best fit for this plugin, apologies for a huge chunk.

mattermod commented 4 years ago

The file .circleci/config.yml is in the blacklist and should not be modified from external contributors, please if you are part of the Mattermost Org submit this PR in the upstream. /cc @mattermost/core-security @mattermost/core-build-engineers

codecov-io commented 4 years ago

Codecov Report

Merging #23 into master will not change coverage by %. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #23   +/-   ##
=======================================
  Coverage   25.25%   25.25%           
=======================================
  Files          82       82           
  Lines        2938     2938           
=======================================
  Hits          742      742           
  Misses       2104     2104           
  Partials       92       92

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cdb7870...cdb7870. Read the comment docs.

mattermod commented 4 years ago

The file .circleci/config.yml is in the blacklist and should not be modified from external contributors, please if you are part of the Mattermost Org submit this PR in the upstream. /cc @mattermost/core-security @mattermost/core-build-engineers

levb commented 4 years ago

@iomodo @larkox I've addressed most of the feedback, and took the liberty of resolving the comments that seemed resolved - just to keep the PR manageable.

1/5 I am inclined to merge this without the full parity with the prior code, and iterate on top of it. The missing functionality

levb commented 4 years ago

@iomodo @larkox I added the /lotto task unassign command to fully merge master, including https://github.com/mattermost/mattermost-plugin-solar-lottery/pull/25. Please confirm and I'll merge,

Apologies, @TheoVitkovskiy this effectively overwrites your commit due to a large refactoring, but I appreciate the contribution!