mattermost-community / mattermost-plugin-solar-lottery

A tool somewhat similar to pager duty, allows to have rotations with magic "solar lottery" scheduling, or overrides.
Apache License 2.0
4 stars 10 forks source link

Rename "new" commands to "create" #34

Open hanzei opened 4 years ago

hanzei commented 4 years ago

This is a great question. In the go code, I try to have the convention of "new" is usually just a memory allocation/simple init, fast and no error possible. "make" can fail. "create" is for creating new persisted entities.

However, I did not stick with the convention for the commands (why??) and in this case the function name is reflective of the command.

Originally posted by @levb in https://github.com/mattermost/mattermost-plugin-solar-lottery/pull/27