search

mattermost-community / mattermost-plugin-solar-lottery

A tool somewhat similar to pager duty, allows to have rotations with magic "solar lottery" scheduling, or overrides.
Apache License 2.0
4 stars 10 forks source link

GH-32 Broken welcome message to self #35

Closed GrigalashviliT closed 4 years ago

GrigalashviliT commented 4 years ago

Summary

Store user before sending welcome message, which solves problem when welcome message is sent to self

Ticket Link

Fixes https://github.com/mattermost/mattermost-plugin-solar-lottery/issues/32

codecov-commenter commented 4 years ago

Codecov Report

Merging #35 into master will decrease coverage by 0.01%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
- Coverage   27.02%   27.01%   -0.02%     
==========================================
  Files          81       81              
  Lines        3289     3291       +2     
==========================================
  Hits          889      889              
- Misses       2298     2300       +2     
  Partials      102      102
Impacted Files Coverage Δ
server/sl/sl_setup.go 0.00% <ø> (ø)
server/sl/sl_user.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 401bf3f...bfbcc6a. Read the comment docs.

hanzei commented 4 years ago

@levb Can this get merged without QA review?