mattermost-community / mattermost-plugin-todo

Mattermost plugin for tracking to do items
Apache License 2.0
67 stars 59 forks source link

test(e2e, playwright): added e2e test for /todo help command #238

Closed rahulsuresh-git closed 4 months ago

rahulsuresh-git commented 9 months ago

Summary

This introduces a Playwright end-to-end (e2e) test to check if the /todo help command functions as expected. We verify the functionality of the various commands available for the Todo plugin.

I've also made a few changes to improve clarity and readability. Verified that the test passes locally.

image
codecov-commenter commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1afeeb0) 6.42% compared to head (18e5802) 6.42%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #238 +/- ## ====================================== Coverage 6.42% 6.42% ====================================== Files 11 11 Lines 1712 1712 ====================================== Hits 110 110 Misses 1594 1594 Partials 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mickmister commented 9 months ago

@toninis Any ideas why we need to press "Approve and run" on each commit of this forked repo PR?

Workflows for this repo are here https://github.com/mattermost/mattermost-plugin-todo/tree/master/.github/workflows. Not sure which ones are the "2 workflows awaiting approval"

CleanShot 2023-12-03 at 21 17 44

toninis commented 9 months ago

@toninis Any ideas why we need to press "Approve and run" on each commit of this forked repo PR?

Workflows for this repo are here https://github.com/mattermost/mattermost-plugin-todo/tree/master/.github/workflows. Not sure which ones are the "2 workflows awaiting approval"

CleanShot 2023-12-03 at 21 17 44

This is the organisation default behaviour on forked PRs for security reasons @mickmister

mickmister commented 9 months ago

@toninis Is this rule enforcement new? I know there is a "first-time contributor" check that has been enabled for a while, though I'm not used to seeing this for every commit

toninis commented 9 months ago

@toninis Is this rule enforcement new? I know there is a "first-time contributor" check that has been enabled for a while, though I'm not used to seeing this for every commit

https://github.com/mattermost/mattermost/pull/25616 It's always like this if I recall

hanzei commented 9 months ago

Removing myself from the list of reviewers until the comments of @mickmister are resolved.

rahulsuresh-git commented 4 months ago

Closing this PR as the changes are moved to this single PR: https://github.com/mattermost-community/mattermost-plugin-todo/pull/254. Note: Comments addressed on the single PR.