search

mattermost-community / mattermost-plugin-todo

Mattermost plugin for tracking to do items
Apache License 2.0
67 stars 59 forks source link

Hamburger menu gone and sidebar not able to be hidden #245

Open Uatschitchun opened 6 months ago

Uatschitchun commented 6 months ago

When clicking on one of the 3 icons in the bottom left for todos, the hamburger menu to hide the sidebar is gone and sidebar can't be hidden.

See attached pictures. Screenshot_20240224_190323 Problem Screenshot_20240224_185549_com opera browser Screenshot_20240224_185555_com opera browser

mickmister commented 6 months ago

Hi @Uatschitchun, thanks for filing this issue. It's a little difficult to tell what's going on here since the screenshots are so zoomed in. Is this occurring in the desktop browser? Would you be able to provide a gif of the issue occurring? I think that would be most helpful in this case. Thank you!

Uatschitchun commented 6 months ago

It's in browser mobile view, so not in desktop view. Try it out on smartphone. Steps to reproduce: When in a channel, opening the sidebar (hamburger menu top-left), there's a hamburger-menu on the top-right to close sidebar again. With sidebar open click on one of the 3 todo-icons in the bottom-left and hamburger-menu (top-right) disappears. So no way to close sidebar

mickmister commented 6 months ago

@Uatschitchun I understand what's going on now. When you click the plugin's items in the LHS, the plugin shows its RHS view, and clicking in that area does not make the channel browsing view slide back over. I've reproduced this with the GitHub plugin as well. Here's a gif reproducing with the todo plugin:

https://github.com/mattermost/mattermost-plugin-todo/assets/6913320/bf245740-f13e-4d4f-b4c4-a8e9f22e39bf

@asaadmahmood Does anything need to change here other than ensuring that touching outside of the channel browsing pane should close it in this view?

Uatschitchun commented 6 months ago

@mickmister Thx for the understanding and the gif!

mickmister commented 6 months ago

@asaadmahmood When you have the chance can you take a look at my comment above?

asaadmahmood commented 6 months ago

@mickmister Ideally, opening another window (like the todo, or github plugin) from the LHS should also close the LHS automatically as its opening something else.

mickmister commented 6 months ago

@asaadmahmood Okay that makes sense. I wonder if it's possible for plugins to force close the LHS to make that happen. Maybe simulating a click when on mobile is all that needs to be done