search

mattermost-community / mattermost-plugin-welcomebot

Apache License 2.0
64 stars 41 forks source link

Bump version to 1.3.0 #105

Closed mickmister closed 1 year ago

mickmister commented 1 year ago

Summary

Ticket Link

trilopin commented 1 year ago

@mickmister note that lint is failing in CI

DHaussermann commented 1 year ago

I have done some testing on this release and there are issues: 1. The issue is fixed but, I can't make that work as a feature. It will just never welcome guests. Maybe I tried this wrong. @streamer45 maybe you have thoughts on this? - Created a guest user and invited them to a team with working welcome message. When the new user logs in for the 1st time they don't get the bot DM even when I add the new field to my config image

  1. There's a feature where you can welcome multiple teams that does not work and should be reverted - https://github.com/mattermost/mattermost-plugin-welcomebot/pull/82
  2. Theres a feature where we add channel level welcome support to private channels that does not work and should be reverted - https://github.com/mattermost/mattermost-plugin-welcomebot/pull/79

@mickmister may be able to help on 2. and 3.

DHaussermann commented 1 year ago

@streamer45 disregard the comment above. This does work as expected. On some attempts to test I forgot to restart the server. And on the last attempt there was a syntax error (which you can even see in the screen shot 🙃)

mickmister commented 1 year ago

Created https://github.com/mattermost/mattermost-plugin-welcomebot/pull/109 to revert: