search

mattermost-community / mattermost-plugin-welcomebot

Apache License 2.0
66 stars 41 forks source link

Revert #82 and #79 #109

Closed mickmister closed 1 year ago

mickmister commented 1 year ago

Summary

Reverts the following PRs due to having incomplete functionality:

I've also reopened the tickets associated with those PRs:

Ticket Link

trilopin commented 1 year ago

Is the missing functionality written anywhere? Can't that be completed without reverting the code?

DHaussermann commented 1 year ago

Thanks @mickmister I see this working as expected for the reverts.

As we are making a last set of changes here, Can you please add something to the read-me that covers an example of using the new guest-account support feature? It would be helpful if you could just add that middle line below to the read-me as you already have changes in. 


                        "DelayInSeconds": 3,
                        "IncludeGuests": false,
                        "Message": [
mickmister commented 1 year ago

As we are making a last set of changes here, Can you please add something to the read-me that covers an example of using the new guest-account support feature? It would be helpful if you could just add that middle line below to the read-me as you already have changes in.

@DHaussermann I'm inclined to do this in a separate PR as it's out of scope of reverting these two PRs. Thoughts on merging this PR as-is?