search

mattermost-community / mattermost-plugin-welcomebot

Apache License 2.0
66 stars 41 forks source link

[GH-108]: Added the setting in the system console for plugin settings #126

Open Kshitij-Katiyar opened 6 months ago

Kshitij-Katiyar commented 6 months ago

Summary

This PR has been created using the PR https://github.com/mattermost/mattermost-plugin-welcomebot/pull/92. It adds a long text field for the plugin configuration settings.

Ticket Link

Fixes https://github.com/mattermost/mattermost-plugin-welcomebot/issues/108 Fixes https://github.com/mattermost/mattermost-plugin-welcomebot/issues/56

Kshitij-Katiyar commented 6 months ago

@mickmister Regarding the QA comment https://github.com/mattermost/mattermost-plugin-welcomebot/pull/92#pullrequestreview-1954295515, I tried making the build from the master branch and deploying it on MM v5.37+ which is its minimum supported version. I am getting the error

"error":"unable to start plugin: com. mattermost.welcomebot: Unrecognized remote plugin message: \n\nThis usually means that the plugin is either invalid or simply\nneeds to be recompiled to support the latest protocol."

But the above builds are working fine on MMv7.8.0+, So here we can do 2 things I can each commit in this plugin and check for which we are actually getting the error and try to debug and fix that or we can just update the minimum supported version for this plugin. But in any case, this error is not related to this PR. cc: @AayushChaudhary0001