search

mattermost-community / mattermost-plugin-welcomebot

Apache License 2.0
66 stars 41 forks source link

[mm-65] Allows users to add multiple teams to the messages using `team-a,team-b` in the messages #82

Closed maisnamrajusingh closed 3 years ago

maisnamrajusingh commented 3 years ago

Summary

I closed the previous PR that had a lot of conflicts and updated the logic here to make the code more simpler and shorter. Users can now configure the messages using team-1, team-2 or team-1, team-2 and the bot will process the message for those teams when running /welcomebot preview team-1 or /welcomebot preview team-2

Ticket Link

https://github.com/mattermost/mattermost-plugin-welcomebot/issues/65

mattermod commented 3 years ago

Hello @maisnamrajusingh,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

maisnamraju commented 3 years ago

Does this change effect the UserHasJoinedTeam hook?

No it doesn't.

hanzei commented 3 years ago

How do these changes ensure that users who join a team get the right message?

mattermod commented 3 years ago

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

/cc @jasonblais @jfrerich @emilyacook

maisnamrajusingh commented 3 years ago

How do these changes ensure that users who join a team get the right message? I was so focussed on the message preview I totally forgot that I needed to get the message to show up when the user joins the team. :man_facepalming:

I have updated the changes so that it hooks to the UserHasJoinedTeam hook

hanzei commented 3 years ago

Let's deffer QA testing to release testing.