search

mattermost / circleci-orbs

Orbs used for building in MM repositories on circleci
3 stars 9 forks source link

Simplify git diff #13

Closed hanzei closed 4 years ago

hanzei commented 4 years ago

Actually, --quiet implies --exit-code which is the real option we want here. Hence, this PR simplifies the code.

agnivade commented 4 years ago

But don't we want to see the results too ? I checked the man page that time itself and did see that quiet implies exit-code. So we can swap the quiet for exit-code in the last command, but we want to see the diff as well right ? Or does this show the diff and exit with the right code too ? In which case, I quickly misread the man page.