[MM-19848] Extract min required server version in release notes

mattermost / circleci-orbs

Orbs used for building in MM repositories on circleci

3 stars 9 forks source link

[MM-19848] Extract min required server version in release notes #9

Closed RajatVaryani closed 4 years ago

RajatVaryani commented 4 years ago

Summary

A lot of logic is taken from goreleaser to generate the release notes. Please take note of special case when it is the first release. For first release a diffrent command is used to generate changelog as there isn't a previous tag to compare to. To understand the command please have a look here

I have tested this orb (used personal clone) by creating a sample plugin and checking the release notes. This is how QA can test the story.

This PR fixes 13587 and fixes 13586

RajatVaryani commented 4 years ago

@hanzei Made the changes. This is how it looks now

You can find the release notes here.

RajatVaryani commented 4 years ago

I won't to be able to contribute to the PR anymore. Hence closing the PR. Please use the code if it seems apt.

metanerd commented 4 years ago

OK, we will look into it, thank you @RajatVaryani

hanzei commented 4 years ago

@RajatVaryani That you very much for all the work you put into this PR. That was awesome :tada: Sorry for letting you hanging a bit.

I've resubmitted your PR as https://github.com/mattermost/circleci-orbs/pull/10 and hope to merge your changes soon.