search

mattermost / desktop

Mattermost Desktop application for Windows, Mac and Linux
Apache License 2.0
2.03k stars 829 forks source link

Forward and previous channel button does not change application title #1563

Open Dartui opened 3 years ago

Dartui commented 3 years ago

I confirm (by marking "x" in the [ ] below: [x]):

Summary

obraz

After clicking forward and previous channel buttons, application title does not change and stays the same.

Environment

Steps to reproduce

  1. Go on Channel 1 - application title changes to Channel 1
  2. Go on Channel 2 - application title changes to Channel 2
  3. Use Previous Channel button - channel is changed to Channel 1, but title says Channel 2

Expected behavior

Title changing with channel change

Observed behavior

Possible fixes

amyblais commented 3 years ago

@Dartui Are you able to reproduce the same on v4.7-rc2 https://github.com/mattermost/desktop/releases?

Dartui commented 3 years ago

@amyblais on Xubuntu, Mattermost 4.7-rc2 does not show channel name in application title at all. There is only "Mattermost Desktop App" in title. Later I will try it on Windows installation.

obraz

Dartui commented 3 years ago

Windows installation has the same application title, no matter of which channel is selected - Mattermost Desktop App.

To be honest I kinda liked seeing what channel I had open, but displaying same title all the time is fixing this issue.

datn commented 3 years ago

Linux application also always displays "Mattermost Desktop App", which is way too long for my task manager and ends up hiding notification numbers. Would appreciate a configurable dynamic title --

amyblais commented 3 years ago

cc @Willyfrog

Willyfrog commented 3 years ago

we removed using the title from the webapp in 4.7, in 5.0 it will be replaced by something more sensible and useful based on the state of the app.

Linux application also always displays "Mattermost Desktop App", which is way too long for my task manager and ends up hiding notification numbers. Would appreciate a configurable dynamic title --

Can you provide a screenshot? from your description looks more like a WM issue rather than an app issue, but I would like to confirm.

datn commented 3 years ago

we removed using the title from the webapp in 4.7, in 5.0 it will be replaced by something more sensible and useful based on the state of the app.

Good to know, thanks.

Can you provide a screenshot? from your description looks more like a WM issue rather than an app issue, but I would like to confirm.

I can't currently, because for my sanity, I actually used a binary editor to modify the app.asar fle to change Mattermost Desktop App to Mattermost. (Then I added an HTML comment to soak up the spaces)

I hope this suffices:

#old 
0031F470  3A 22 3E 0A 20 20 20 20 3C 74 69 74 6C 65 3E 4D 61 74 74 65 72 6D 6F 73 :">.    <title>Mattermos
0031F488  74 20 44 65 73 6B 74 6F 70 20 41 70 70 3C 2F 74 69 74 6C 65 3E 0A 20 20 t Desktop App</title>.

#new
0031F470  3A 22 3E 0A 20 20 20 20 3C 74 69 74 6C 65 3E 6D 61 74 74 65 72 6D 6F 73 :">.    <title>mattermos
0031F488  74 3C 2F 74 69 74 6C 65 3E 20 20 3C 21 2D 2D 20 20 20 20 20 2D 2D 3E 20 t</title>  <!--     -->
devinbinnie commented 2 years ago

@datn What sort of information would you like to see in the title going forward?

datn commented 2 years ago

Thanks for this. Ideally a customizable title, but mainly this: a title should be as short as possible while distinguishing itself from others. I already know it's an app, and I don't need the desktop app distinguished from the mobile app because they run on separate platforms. So "Mattermost" is all that's needed.

devinbinnie commented 2 years ago

cc @esethna

esethna commented 2 years ago

@datn makes sense. Are you open to submitting a PR to shorten the title to "Mattermost" instead of "Mattermost Desktop App"?