Tray icon shows non-applicable keyboard shortcuts

nmatt commented 8 years ago

I confirm (by marking "x" in the [ ] below):

[x] This is not a feature idea. Feature ideas go here: http://www.mattermost.org/feature-ideas/
[x] This is not a troubleshooting question. Troubleshooting questions go here: http://www.mattermost.org/troubleshoot/
[x] This is a product defect issue that can be reproduced using the steps listed below.
[x] I have read CONTRIBUTING.md.

Summary

The team menu items in the menu tray icon’s context menu show the Ctrl+ keyboard shortcuts, however these are only applicable within the application window.

Steps to reproduce

Please include:

Operating System: Windows 7 Pro
Mattermost Desktop App version: 1.3.0
Mattermost Server version (See Main Menu > About Mattermost) :
Clear steps to reproduce the issue: Right-click on the Mattermost tray icon
Expected behavior

No keyboard shortcut should be shown on the team menu items in the tray icon’s context menu (unless a feature for global hotkeys is added).

Observed behavior

The team menu items in the tray icon’s context menu show the Ctrl+ keyboard shortcuts, which are only applicable within the application window.

Possible fixes

Don't reuse the exact same team menu items from the "Window" menu for the tray icon's context menu.

razzeee commented 8 years ago

Not sure if this is valid on the other operatingsystems, but on windows it's indeed not useable. Only other app that also has these set, that I have installed is slack. They probably also did it on error? Not sure.

jasonblais commented 8 years ago

Thanks @nmatt, good point indeed.

I think it's re-using the shortcuts from Menu Bar > Window, so it would be a matter of removing the keyboard shortcuts from the list that appears after right-clicking the system tray icon.

@Razzeee Would you be interested in looking into a fix?

jasonblais commented 8 years ago

@mmahkamov @jnugh @timroes @akashnimare: Would you be able to verify if this reproduces on OS X and Linux?

akashnimare commented 8 years ago

I am not sure what he's trying to say. It's working fine on OS X.

razzeee commented 8 years ago

@akashnimare even if you have the app in the background?

@jasonblais can do a pr but want to know hot it's handled on all platforms first ;)

yuya-oc commented 8 years ago

In my understanding,

Windows: Should not work (Tray should get focus to use, but maybe cannot).
OS X: Should not work (Probably application's menu is working).
Linux: I'm not sure.

razzeee commented 8 years ago

Then I'll just remove the accelerators from there.

mmahkamov commented 8 years ago

The issue is replicable on OS X 10.11.5, Mattermost Desktop 1.3.0 (actually it's an RC release but the about window doesn't show which one).

Pre-requisites:

Mattermost Desktop window is inactive
Some other window is active (e.g. Xcode)

Now if you click on the tray icon of Mattermost Desktop you'll see shortcuts listed for the team (Command + 1 in my case). Pressing Command + 1 in the active window (Xcode) won't switch me to Mattermost Desktop because that's not a global hotkey.

yuya-oc commented 8 years ago

Yeah, so #242 removes the shortcuts from the tray icon.

mattermost / desktop