mattermost / desktop

Mattermost Desktop application for Windows, Mac and Linux
Apache License 2.0
2k stars 816 forks source link

[Snyk] Security upgrade bootstrap from 4.6.1 to 5.0.0 #3089

Closed mm-prodsec-bot closed 2 months ago

mm-prodsec-bot commented 2 months ago

This PR was automatically created by Snyk using the credentials of a real user.


![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123) ### Snyk has created this PR to fix 2 vulnerabilities in the npm dependencies of this project. #### Snyk changed the following file(s): - `package.json` - `package-lock.json` #### Vulnerabilities that will be fixed with an upgrade: | | Issue | Score | :-------------------------:|:-------------------------|:------------------------- ![medium severity](https://res.cloudinary.com/snyk/image/upload/w_20,h_20/v1561977819/icon/m.png 'medium severity') | Cross-site Scripting (XSS)
[SNYK-JS-BOOTSTRAP-7444580](https://snyk.io/vuln/SNYK-JS-BOOTSTRAP-7444580) |   **688**   ![medium severity](https://res.cloudinary.com/snyk/image/upload/w_20,h_20/v1561977819/icon/m.png 'medium severity') | Cross-site Scripting
[SNYK-JS-BOOTSTRAP-7444617](https://snyk.io/vuln/SNYK-JS-BOOTSTRAP-7444617) |   **688**   --- > [!IMPORTANT] > > - Check the changes in this PR to ensure they won't cause issues with your project. > - Max score is 1000. Note that the real score may have changed since the PR was raised. > - This PR was automatically created by Snyk using the credentials of a real user. --- **Note:** _You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs._ For more information: 🧐 [View latest project report](https://app.snyk.io/org/mattermost-core/project/95008d4a-00ef-4968-93b7-7aacb32fd9fc?utm_source=github-enterprise&utm_medium=referral&page=fix-pr) 📜 [Customise PR templates](https://docs.snyk.io/scan-using-snyk/pull-requests/snyk-fix-pull-or-merge-requests/customize-pr-templates) 🛠 [Adjust project settings](https://app.snyk.io/org/mattermost-core/project/95008d4a-00ef-4968-93b7-7aacb32fd9fc?utm_source=github-enterprise&utm_medium=referral&page=fix-pr/settings) 📚 [Read about Snyk's upgrade logic](https://support.snyk.io/hc/en-us/articles/360003891078-Snyk-patches-to-fix-vulnerabilities) --- **Learn how to fix vulnerabilities with free interactive lessons:** 🦉 [Cross-site Scripting (XSS)](https://learn.snyk.io/lesson/dom-based-xss/?loc=fix-pr) [//]: # 'snyk:metadata:{"customTemplate":{"variablesUsed":[],"fieldsUsed":[]},"dependencies":[{"name":"bootstrap","from":"4.6.1","to":"5.0.0"}],"env":"prod","issuesToFix":[{"exploit_maturity":"Proof of Concept","id":"SNYK-JS-BOOTSTRAP-7444580","priority_score":688,"priority_score_factors":[{"type":"exploit","label":"Proof of Concept","score":107},{"type":"freshness","label":true,"score":71},{"type":"fixability","label":true,"score":214},{"type":"cvssScore","label":"5.9","score":295},{"type":"scoreVersion","label":"v1","score":1}],"severity":"medium","title":"Cross-site Scripting (XSS)"},{"exploit_maturity":"Proof of Concept","id":"SNYK-JS-BOOTSTRAP-7444617","priority_score":688,"priority_score_factors":[{"type":"exploit","label":"Proof of Concept","score":107},{"type":"freshness","label":true,"score":71},{"type":"fixability","label":true,"score":214},{"type":"cvssScore","label":"5.9","score":295},{"type":"scoreVersion","label":"v1","score":1}],"severity":"medium","title":"Cross-site Scripting"}],"prId":"62619db9-4c62-4343-81ef-af5be72b0931","prPublicId":"62619db9-4c62-4343-81ef-af5be72b0931","packageManager":"npm","priorityScoreList":[688,688],"projectPublicId":"95008d4a-00ef-4968-93b7-7aacb32fd9fc","projectUrl":"https://app.snyk.io/org/mattermost-core/project/95008d4a-00ef-4968-93b7-7aacb32fd9fc?utm_source=github-enterprise&utm_medium=referral&page=fix-pr","prType":"fix","templateFieldSources":{"branchName":"default","commitMessage":"default","description":"default","title":"default"},"templateVariants":["updated-fix-title","priorityScore"],"type":"auto","upgrade":["SNYK-JS-BOOTSTRAP-7444580","SNYK-JS-BOOTSTRAP-7444617"],"vulns":["SNYK-JS-BOOTSTRAP-7444580","SNYK-JS-BOOTSTRAP-7444617"],"patch":[],"isBreakingChange":true,"remediationStrategy":"vuln"}'
mm-cloud-bot commented 2 months ago

@mm-prodsec-bot: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed [here](https://chewbacca.core.cloud.mattermost.com/command-help.html)
devinbinnie commented 2 months ago

This will cause some breakage if we just change the version like this. cc @esarafianou Can we just create an issue for this? Not sure what the procedure is here (this bot is new to me :P)

esarafianou commented 2 months ago

@devinbinnie you can ignore it and close the PR for now. We need to see if we can have those PRs created only for patch and minor versions. cc. @enzowritescode