[Bug]: Minor UX: Update downloader does not indicate active download + can crash on repeated click

[bjoernmartin]

Checks before filing an issue

• [X] This issue doesn't reproduce on web browsers (such as in Chrome). If it does, issue reports go to the Mattermost Server repository.
• [X] I have checked the issue tracker and have not found an issue that matches the one I'm filing.
• [X] This issue is not a troubleshooting question. Troubleshooting questions go here: https://forum.mattermost.com/c/trouble-shoot/16.
• [X] This issue is not a feature request. You can request features and make product suggestions here: https://mattermost.com/suggestions/.
• [X] This issue reproduces on the most recent stable version, or the most recent prerelease version of the Mattermost Desktop App.
• [X] I have read the contribution guidelines.

Mattermost Desktop Version

5.8.1

Operating System

Windows 11 x64

Mattermost Server Version

EE 9.5.6

Steps to reproduce

• Wait for an update to a new version
• Click Download Update button of the update popup in the top-right corner (see screenshot)
• Click the button repeatedly due to no reaction

Expected behavior

• Download Update button is disabled / replaced by a Downloading... indicator once the download starts

Observed behavior

• Download Update button stays enabled, no other reaction from the UI
• Repeated clicks on the button crashed the app with an error message indicating access to the update .exe is not allowed
  • No screenshot, sorry, but the log shows the error: There was an error while trying to update Error: EPERM: operation not permitted, open 'C:\Users\**user**\AppData\Local\mattermost-desktop-updater\pending\temp-mattermost-desktop-setup-5.9.0-win.exe'

Log Output

[2024-08-16 05:26:14.500] [info]  [UpdateManager] Checking for update
[2024-08-16 05:26:17.677] [error] [UpdateManager] Error: Error: net::ERR_NETWORK_IO_SUSPENDED
    at SimpleURLLoaderWrapper.<anonymous> (node:electron/js2c/browser_init:2:109791)
    at SimpleURLLoaderWrapper.emit (node:events:514:28)
[2024-08-16 05:26:17.678] [error] [UpdateManager] There was an error while trying to update Error: net::ERR_NETWORK_IO_SUSPENDED
    at SimpleURLLoaderWrapper.<anonymous> (node:electron/js2c/browser_init:2:109791)
    at SimpleURLLoaderWrapper.emit (node:events:514:28)
[2024-08-16 05:26:17.681] [error] [UpdateManager] Failed to check for updates: Error: net::ERR_NETWORK_IO_SUSPENDED
    at SimpleURLLoaderWrapper.<anonymous> (node:electron/js2c/browser_init:2:109791)
    at SimpleURLLoaderWrapper.emit (node:events:514:28)
[2024-08-16 05:26:18.337] [error] [WebContentsEventM...] [Mattermost] [TAB_MESSAGING] [renderer] TypeError: Failed to fetch
[2024-08-16 05:26:18.415] [error] [WebContentsEventM...] [Mattermost] [TAB_MESSAGING] [renderer] com.mattermost.calls: TypeError: Failed to fetch
[2024-08-16 05:26:18.421] [error] [WebContentsEventM...] [Mattermost] [TAB_MESSAGING] [renderer] Uncaught (in promise) TypeError: Failed to fetch
[2024-08-16 05:26:18.521] [error] [WebContentsEventM...] [Mattermost] [TAB_MESSAGING] [renderer] com.mattermost.calls: TypeError: Failed to fetch
[2024-08-16 05:26:24.400] [info]  [App.Config] config.autostart has been configured: true
[2024-08-16 06:26:17.679] [info]  [UpdateManager] Checking for update
[2024-08-16 06:26:17.900] [info]  [UpdateManager] Found version 5.9.0 (url: 5.9.0/mattermost-desktop-setup-5.9.0-win.exe)
[2024-08-16 06:26:17.902] [info]  [UpdateManager] New version available: 5.9.0
[2024-08-16 06:26:42.988] [info]  [UpdateManager] Downloading update from 5.9.0/mattermost-desktop-setup-5.9.0-win.exe
[2024-08-16 06:26:43.008] [info]  [UpdateManager] Cached update sha512 checksum doesn't match the latest available update. New update must be downloaded. Cached: WN50bN8A+5ubG+MyFpmkyJc/GFItGwVItFO3p0hrp//45KkDn0+4AXq4iC7loMr6Ab64KY2vGRFRHsY/S4O88w==, expected: qAd3ONlaNdgIFCnRGi7pinsPaxPf9lQoH5taL0M0/1n8VnMCB4wePP/lsD5VPW7oKU4ZGZUj3VDrCJ0Iro4E/A==. Directory for cached update will be cleaned
[2024-08-16 06:26:43.012] [info]  [UpdateManager] Download block maps (old: "https://releases.mattermost.com/desktop/5.8.1/mattermost-desktop-setup-5.8.1-win.exe.blockmap", new: https://releases.mattermost.com/desktop/5.9.0/mattermost-desktop-setup-5.9.0-win.exe.blockmap)
[2024-08-16 06:26:43.568] [info]  [UpdateManager] File has 7959 changed blocks
[2024-08-16 06:26:43.577] [info]  [UpdateManager] Full: 164,231.01 KB, To download: 163,437.47 KB (100%)
[2024-08-16 06:27:16.725] [info]  [UpdateManager] Downloading update from 5.9.0/mattermost-desktop-setup-5.9.0-win.exe
[2024-08-16 06:27:16.729] [info]  [UpdateManager] Download block maps (old: "https://releases.mattermost.com/desktop/5.8.1/mattermost-desktop-setup-5.8.1-win.exe.blockmap", new: https://releases.mattermost.com/desktop/5.9.0/mattermost-desktop-setup-5.9.0-win.exe.blockmap)
[2024-08-16 06:27:17.382] [info]  [UpdateManager] File has 7959 changed blocks
[2024-08-16 06:27:17.383] [info]  [UpdateManager] Full: 164,231.01 KB, To download: 163,437.47 KB (100%)
[2024-08-16 06:27:17.384] [error] [UpdateManager] Cannot download differentially, fallback to full download: Error: EPERM: operation not permitted, open 'C:\Users\**user**\AppData\Local\mattermost-desktop-updater\pending\temp-mattermost-desktop-setup-5.9.0-win.exe'
[2024-08-16 06:27:17.684] [info]  [UpdateManager] Downloading update from 5.9.0/mattermost-desktop-setup-5.9.0-win.exe
[2024-08-16 06:27:17.686] [warn]  [UpdateManager] Error on remove temp update file: Error: EPERM: operation not permitted, unlink 'C:\Users\**user**\AppData\Local\mattermost-desktop-updater\pending\temp-mattermost-desktop-setup-5.9.0-win.exe'
[2024-08-16 06:27:17.686] [info]  [UpdateManager] Download block maps (old: "https://releases.mattermost.com/desktop/5.8.1/mattermost-desktop-setup-5.8.1-win.exe.blockmap", new: https://releases.mattermost.com/desktop/5.9.0/mattermost-desktop-setup-5.9.0-win.exe.blockmap)
[2024-08-16 06:27:18.027] [info]  [UpdateManager] Downloading update from 5.9.0/mattermost-desktop-setup-5.9.0-win.exe
[2024-08-16 06:27:18.029] [warn]  [UpdateManager] Error on remove temp update file: Error: EPERM: operation not permitted, unlink 'C:\Users\**user**\AppData\Local\mattermost-desktop-updater\pending\temp-mattermost-desktop-setup-5.9.0-win.exe'
[2024-08-16 06:27:18.030] [info]  [UpdateManager] Download block maps (old: "https://releases.mattermost.com/desktop/5.8.1/mattermost-desktop-setup-5.8.1-win.exe.blockmap", new: https://releases.mattermost.com/desktop/5.9.0/mattermost-desktop-setup-5.9.0-win.exe.blockmap)
[2024-08-16 06:27:18.076] [error] [UpdateManager] Error: Error: EPERM: operation not permitted, open 'C:\Users\**user**\AppData\Local\mattermost-desktop-updater\pending\temp-mattermost-desktop-setup-5.9.0-win.exe'
[2024-08-16 06:27:18.076] [error] [UpdateManager] There was an error while trying to update Error: EPERM: operation not permitted, open 'C:\Users\**user**\AppData\Local\mattermost-desktop-updater\pending\temp-mattermost-desktop-setup-5.9.0-win.exe'
[2024-08-16 06:27:19.902] [info]  [UpdateManager] File has 7959 changed blocks
[2024-08-16 06:27:19.903] [info]  [UpdateManager] Full: 164,231.01 KB, To download: 163,437.47 KB (100%)
[2024-08-16 06:27:21.408] [info]  [UpdateManager] File has 7959 changed blocks
[2024-08-16 06:27:21.409] [info]  [UpdateManager] Full: 164,231.01 KB, To download: 163,437.47 KB (100%)
[2024-08-16 06:28:08.971] [error] Logger Log level set to: info
[2024-08-16 06:28:09.212] [info]  [App.Config] config.autostart has been configured: true
[2024-08-16 06:28:09.259] [info]  [App.Config] config.autostart has been configured: true
[2024-08-16 06:28:09.408] [info]  [ServerDropdownView] init
[2024-08-16 06:28:09.477] [warn]  [i18nManager] Failed to set new language en-US
[2024-08-16 06:28:09.478] [warn]  [i18nManager] Failed to set new language DE
[2024-08-16 06:28:09.497] [info]  [App.Config] config.autostart has been configured: true
[2024-08-16 06:28:09.531] [info]  [App.Config] config.autostart has been configured: true
[2024-08-16 06:28:09.985] [info]  [App.Config] config.autostart has been configured: true
[2024-08-16 06:28:14.367] [info]  [UpdateManager] Checking for update
[2024-08-16 06:28:14.630] [info]  [UpdateManager] Found version 5.9.0 (url: 5.9.0/mattermost-desktop-setup-5.9.0-win.exe)
[2024-08-16 06:28:14.633] [info]  [UpdateManager] New version available: 5.9.0
[2024-08-16 06:28:17.547] [info]  [UpdateManager] Downloading update from 5.9.0/mattermost-desktop-setup-5.9.0-win.exe
[2024-08-16 06:28:17.551] [info]  [UpdateManager] Download block maps (old: "https://releases.mattermost.com/desktop/5.8.1/mattermost-desktop-setup-5.8.1-win.exe.blockmap", new: https://releases.mattermost.com/desktop/5.9.0/mattermost-desktop-setup-5.9.0-win.exe.blockmap)
[2024-08-16 06:28:17.809] [info]  [UpdateManager] File has 7959 changed blocks
[2024-08-16 06:28:17.817] [info]  [UpdateManager] Full: 164,231.01 KB, To download: 163,437.47 KB (100%)
[2024-08-16 06:29:08.934] [info]  [UpdateManager] New version 5.9.0 has been downloaded to C:\Users\**user**\AppData\Local\mattermost-desktop-updater\pending\mattermost-desktop-setup-5.9.0-win.exe
[2024-08-16 06:29:08.938] [info]  [UpdateManager] Downloaded version 5.9.0

Additional Information

• The Task Manager shows that the download did in fact start, so does the log
• Simply waiting after clicking the button once works, so this is "just" a minor UX thing
• I had to tick the most recent stable version above even though I obviously had to be on the previous one, otherwise this issue cannot be observed ^^

[devinbinnie]

Can reproduce. Thanks, created a ticket: https://mattermost.atlassian.net/browse/MM-60224