MM-60224 - disable upgrade app button once download starts

pvev commented 1 month ago

Summary

There was a problem with the upgrade app button were once the user clicked it and the download started, the button kept enabled so users could click it multiple times causing the app to crash, even thought the download and the upgrade completed successfully. This PR makes sure to disable the button once the download has started and provides feedback using a loading spinner and showing Downloading text in the button.

Ticket Link

https://mattermost.atlassian.net/browse/MM-60224

Checklist

[ ] Added or updated unit tests (required for all new features)
[ ] Has UI changes
[ ] read and understood our Contributing Guidelines
[ ] completed Mattermost Contributor Agreement
[ ] executed npm run lint:js for proper code formatting
[ ] Run E2E tests by adding label Run Desktop E2E Tests

Device Information

This PR was tested on:

Screenshots

Before: (In this before example the app do not crash, I was able to only make it crash one out of 4)

https://github.com/user-attachments/assets/96ad3122-44be-4d98-b3e0-780529c4fb93

After:

https://github.com/user-attachments/assets/300c6f22-eb15-42e4-adc4-be7f1a0ec5d7

Release Note

NONE

github-actions[bot] commented 1 month ago

Here are the test results below:

Test Summary for Linux on commit 39753af3a4f8b0da6269ac2e0e4fcb219760577d

New failed tests found on Linux:

menu/view MM-T816 Toggle Full Screen in the Menu Bar

Test Summary for macOS on commit 39753af3a4f8b0da6269ac2e0e4fcb219760577d

All stable tests passed on macOS.

github-actions[bot] commented 1 month ago

Here are the test results below:

Test Summary for Linux on commit 39753af3a4f8b0da6269ac2e0e4fcb219760577d

New failed tests found on Linux:

menu/view MM-T816 Toggle Full Screen in the Menu Bar

Test Summary for macOS on commit 39753af3a4f8b0da6269ac2e0e4fcb219760577d

All stable tests passed on macOS.

yasserfaraazkhan commented 1 month ago

Hi @devinbinnie @pvev how do we reduce the version and test this change ? can you share QA steps?

pvev commented 1 month ago

Hi @devinbinnie @pvev how do we reduce the version and test this change ? can you share QA steps?

hey @yasserfaraazkhan , sorry, I forgot to mentioned it here but I already asked @devinbinnie and I created a fake PR with 5.8 base + this changes to get the CI build the packages that will detect the upgrade to 5.9. PR is here: https://github.com/mattermost/desktop/pull/3169

pvev commented 1 month ago

@pvev tested this on windows and macos we can see the button get disabled.

I observed that in Dark more (OS's set it dark mode) we dont see download button.

If this is an existing issue then its not a blocker. If not should this be fixed in this PR or separately. Please let me know.

fixed (and also fixed the clear all disabled button styles):

https://github.com/user-attachments/assets/cbacedcc-307f-42ee-9be9-9e459d4c79e2

mattermost / desktop