Closed devinbinnie closed 1 month ago
Here are the test results below:
New failed tests found on Linux:
All stable tests passed on macOS.
verified e2e tests locally. No blocking failures.
@amyblais Am I okay to cherry-pick this to v5.10 to include in the next RC?
Am I okay to cherry-pick this to v5.10 to include in the next RC?
I think this would be better for v5.11 unless this is considered to be urgent for v5.10. I thought you were planning only bug fixes for RC-2. We are cherry-picking to v5.10
/cherry-pick release-5.10
Cherry pick is scheduled.
@devinbinnie - Are there any product or dev docs updates needed for this PR from your perspective?
@devinbinnie - Are there any product or dev docs updates needed for this PR from your perspective?
Dev docs would be helpful, but I likely won't be able to get to it any time soon. Product doc wise - maybe we can add something for the upcoming dashboard? https://mattermost.atlassian.net/browse/MM-60613
Summary
This PR contains a new module called
performanceMonitor
, which is responsible for:This monitoring will take CPU and memory usage data and send it to servers that have elected to subscribe to the Desktop App for performance data. This data will then be available to administrators via Prometheus.
The idea behind this is to get a better idea of how hard users are getting hit in terms of system resources by various parts of our app. The data is divided up by unique process, so that should give us some idea of which part of the app is causing issues if there is a lot of system resources being dedicated to a process.
Not in scope for this change are load times, which we will calculate and send as part of a separate API created later.
Ticket Link
https://mattermost.atlassian.net/browse/MM-60610 https://mattermost.atlassian.net/browse/MM-60086
Screenshots