search

mattermost / desktop

Mattermost Desktop application for Windows, Mac and Linux
Apache License 2.0
2.03k stars 829 forks source link

[MM-61058] Upgrade `electron-log`, turn on async logging #3173

Closed devinbinnie closed 4 weeks ago

devinbinnie commented 1 month ago

Summary

This PR turns on async logging for the Desktop App, as the default behaviour of electron-log is to write synchronously and wait on the main thread. Also I have upgraded electron-log to the latest released version.

This should address issues for those with endpoint security/AV software running, or users on a weaker/slower disk that are experiencing slowness in the app, especially while on a higher logging level.

Ticket Link

https://mattermost.atlassian.net/browse/MM-61058

Upgrade `electron-log`, turn on async logging
devinbinnie commented 4 weeks ago

@amyblais Would we be okay to cherry-pick this into v5.10? It's a pretty big performance improvement for people with weak disks/have certain AV solutions installed.

amyblais commented 4 weeks ago

Would we be okay to cherry-pick this into v5.10? It's a pretty big performance improvement for people with weak disks/have certain AV solutions installed.

@devinbinnie Sounds good.

amyblais commented 4 weeks ago

/cherry-pick release-5.10

mattermost-build commented 4 weeks ago

Cherry pick is scheduled.