mattermost / desktop

Mattermost Desktop application for Windows, Mac and Linux
Apache License 2.0
2.03k stars 829 forks source link

[MM-59483] Remove legacy preload and custom login code #3174

Closed devinbinnie closed 3 weeks ago

devinbinnie commented 1 month ago

Summary

This PR removes code in the Desktop App that was left to support older versions of the Mattermost Server/Web App:

What this does mean is that as of this change, Mattermost servers running versions under v9.4 will now have a reduced experience, and may or may not function at all. We will be dropping support for those server versions in the Desktop App officially as of v5.11.

This is being done to both reduce complication, improve security (in the case of custom logins) and potentially improve performance (in the case of the preload script changes)

Ticket Link

https://mattermost.atlassian.net/browse/MM-59843

Remove legacy code for older unsupported Mattermost servers
devinbinnie commented 1 month ago

@yasserfaraazkhan We can test this whenever, but since we're removing support for older versions, we should double check that the versions we support are all working well :) I ran E2E tests on my local machine and everything went okay - but a bit more thorough testing seems applicable here.

github-actions[bot] commented 1 month ago

Here are the test results below:

Test Summary for Linux on commit 3b51570f4a63024eddb739386647daa894d58d4b

New failed tests found on Linux:

Test Summary for macOS on commit 3b51570f4a63024eddb739386647daa894d58d4b

All stable tests passed on macOS.