[MM-59823] Migrate `BrowserView` to `WebContentsView`

mattermost / desktop

Mattermost Desktop application for Windows, Mac and Linux

Apache License 2.0

2.03k stars 829 forks source link

[MM-59823] Migrate `BrowserView` to `WebContentsView` #3177

Closed devinbinnie closed 3 weeks ago

devinbinnie commented 4 weeks ago

Summary

A while back, Electron implemented BrowserView as an experimental way of nesting sandboxed Chromium views inside of a main windows, replacing webview. However, for the longest time that functionality remained experimental and not fully supported.

This PR migrates us over to the new WebContentsView, introduced in Electron 30 which should be more stable and supported. It should also simplify resizing logic.

Ticket Link

https://mattermost.atlassian.net/browse/MM-59823

NONE

github-actions[bot] commented 4 weeks ago

Here are the test results below:

Test Summary for Linux on commit a0c98b617f6aaefdc7562de0c60128fadf3b10ca

The following known failed tests have been fixed on Linux:

menu/view MM-T820 should open Developer Tools For Application Wrapper for main window

Test Summary for macOS on commit a0c98b617f6aaefdc7562de0c60128fadf3b10ca

New failed tests found on macOS:

Add Server Modal MM-T1312 should focus the first text input

The following known failed tests have been fixed on macOS:

popup MM-T2827_1 should be able to select all in popup windows

Test Summary for Windows on commit a0c98b617f6aaefdc7562de0c60128fadf3b10ca

All stable tests passed on Windows.

devinbinnie commented 3 weeks ago

/update-branch

devinbinnie commented 3 weeks ago

@enahum Gentle ping for review :) let me know if I need to re-assign

enahum commented 3 weeks ago

@enahum Gentle ping for review :) let me know if I need to re-assign

Sorry was not in my radar, I can give it a review in about 12h or so