mattermost / desktop

Mattermost Desktop application for Windows, Mac and Linux
Apache License 2.0
2.03k stars 829 forks source link

Fix Digest Mismatch error on Enterprise Linux installations when FIPS mode enabled #3191

Closed jonathan-dove closed 2 weeks ago

jonathan-dove commented 2 weeks ago

Summary

Added fpm argument to the package.json file to change the hashing algorithm from md5 to sha256. This fixes an issue introduced in RHEL8+ and/or clones where if FIPS mode is enabled rpm digests must be hashed with at minimum sha256 to be allowed to be installed without bypassing security measures put in place by the FIPS standards.

Ticket Link

https://github.com/mattermost/desktop/issues/3190

Checklist

Device Information

This PR was tested on: RHEL 8, RHEL 9, Rocky9, Rocky8

Release Note

Modified rpm-digest to utilize sha256 instead of md5 to all for rpm installation on FIPS mode enabled Enterprise Linux systems.
mattermost-build commented 2 weeks ago

Hello @jonathan-dove,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

devinbinnie commented 2 weeks ago

@jonathan-dove Thanks for the PR! So those changes actually need to go into electron-builder.json. There's already an fpm section there, so you can add the command line option there.

jonathan-dove commented 2 weeks ago

@jonathan-dove Thanks for the PR! So those changes actually need to go into electron-builder.json. There's already an fpm section there, so you can add the command line option there.

Fantastic. I will move this there. Thanks! @devinbinnie Should this be a seperate pull request or should I just add a commit to this PR?