Fixed issues with loading the app from cold when deep linking

mattermost / desktop

Mattermost Desktop application for Windows, Mac and Linux

Apache License 2.0

2.03k stars 829 forks source link

Fixed issues with loading the app from cold when deep linking #3201

Closed devinbinnie closed 1 week ago

devinbinnie commented 1 week ago

Summary

While working on https://github.com/mattermost/desktop/pull/3200 I found an issue with deep linking when booting the app from cold. The application would fail to load the initial server, and the dropdown menu would also not load. This was caused by the main window creation call happening too early, before a bunch of other setup code could be run.

This PR fixes the issue by having the application wait for the main window to be created normally, before attempting to deep link.

Fixed issues with loading the app from cold when deep linking

devinbinnie commented 1 week ago

@amyblais This might be a case for a dot release for v5.10 - as the app is somewhat unusable when users get into this state. The server will load on v5.10, but the dropdown fails.

github-actions[bot] commented 1 week ago

Here are the test results below:

Test Summary for Linux on commit d0355cba4a480d7e492662f96a1cb41a5d6bfc7c

The following known failed tests have been fixed on Linux:

menu/view MM-T820 should open Developer Tools For Application Wrapper for main window

Test Summary for macOS on commit d0355cba4a480d7e492662f96a1cb41a5d6bfc7c

The following known failed tests have been fixed on macOS:

popup MM-T2827_1 should be able to select all in popup windows

mattermost-build commented 1 week ago

Cherry pick is scheduled.