Closed devinbinnie closed 1 week ago
Here are the test results below:
The following known failed tests have been fixed on Linux:
New failed tests found on macOS:
The following known failed tests have been fixed on macOS:
might be a rare cases, that can occur when typing
- typing Capital HTTPS, changes it into lower and adds https
Will make a fix for this.
Summary
In circumstances where the user stopped typing, or was slow typing the beginning of their server URL, the URL validation would kick in and erroneously mistake the beginning of a URL (ie. any substring of
https://
) as a hostname, and try to addhttps://
for the user. This would cause some confusion and frustration for users trying to type.This PR fixes the validation to recognize any leading substring of
https://
as an invalid URL before it tries to call it a hostname. This stops the user from having to backspace and correct themselves while typing, and should still server to help people typing without the leadinghttps://
. Additionally, I added a QoL fix to stop the trailing/
from appearing while you were typing a host name, so that if you do stop, you don't have to backspace the/
first to keep typing the name.Ticket Link
https://mattermost.atlassian.net/browse/MM-53799