mattermost / desktop

Mattermost Desktop application for Windows, Mac and Linux
Apache License 2.0
2.02k stars 827 forks source link

App crashes after toggling "Show Mattermost icon in menu bar" setting #706

Closed jasonblais closed 6 years ago

jasonblais commented 6 years ago

I confirm (by marking "x" in the [ ] below: [x]):


Summary Mac: App crashes after toggling "Show Mattermost icon in menu bar" setting

Steps to reproduce

Mac; Mattermost desktop app v4.0.0; Mattermost server v4.6.0;

  1. Go to the Settings page via CMD+COMMA
  2. Enable "Show Mattermost icon in menu bar" setting. Then disable it.

Expected behavior Setting enabled, then disabled.

Observed behavior App crashes

image

Details:

Application: Mattermost 4.0.0
Platform: Darwin 16.7.0 x64
TypeError: Cannot read property 'setContextMenu' of null
    at EventEmitter.ipcMain.on (/private/var/folders/s7/wkz14w4s3vq__njkt9j5jrhc0000gn/T/AppTranslocation/DA6D1006-087E-4608-BAAF-FD2C60F3F716/d/Mattermost 6.app/Contents/Resources/app.asar/main_bundle.js:8214:15)
    at emitTwo (events.js:106:13)
    at EventEmitter.emit (events.js:194:7)
    at WebContents.<anonymous> (/private/var/folders/s7/wkz14w4s3vq__njkt9j5jrhc0000gn/T/AppTranslocation/DA6D1006-087E-4608-BAAF-FD2C60F3F716/d/Mattermost 6.app/Contents/Resources/electron.asar/browser/api/web-contents.js:247:13)
    at emitTwo (events.js:106:13)
    at WebContents.emit (events.js:194:7)

Possible fixes ?

yuya-oc commented 6 years ago

Closed via #720.

jasonblais commented 6 years ago

Thanks @yuya-oc!! :)