Closed ctlaltdieliet closed 2 years ago
I took a look at this and have a few suggestions:
double_languages.py
, I suggest marking the duplicate language as disabled/inactive/inaccessible instead of deleting the duplicate outright; this would mitigate accidental deletiondouble_languages.py
, I suggest the error handling around deleting a duplicate language be modified to give a reason for a failuredouble_languages.py
, the error handling doesn't distinguish between an error hitting the Mattermost webhook and an error deleting a language in Weblate; I suggest the error handling be modified to show a different message in each caseweblate_locks_notify_community.py
, I suggest the error handling around hitting the Mattermost webhook be modified to give a reason for a failureIt looks good otherwise! :smile:
Thanks for reviewing this, @neflyte!
Hi @neflyte, thank you for the review. I've modified the scripts with your suggestions. Your suggestions made it way much better!
Summary
Adding some scripts that are using the weblate API to give feedback to the i18n-channel @cwarnermm