search

mattermost / mattermost-developer-documentation

Mattermost developer documentation.
https://developers.mattermost.com
BSD 3-Clause "New" or "Revised" License
80 stars 389 forks source link

Update 404.html #1299

Closed emdecr closed 10 months ago

emdecr commented 10 months ago

Summary

This PR adds markup to the 404 template, so we can use it for our custom error response.

To view template: visit /404.html

Ticket Link

https://mattermost.atlassian.net/browse/MM-54776

emdecr commented 10 months ago

@iyampaul for visibility

cwarnermm commented 10 months ago

@emdecr - Looks like one of the merge checks includes running some kind of HTML check that's failing. This is the first time I've seen these errors, and I'm not sure how many, if any, we can safely ignore.

emdecr commented 10 months ago

@cwarnermm Haha – maybe this is why it was empty 😁 Works locally when you visit http://localhost:1313/404.html, but lemme look around to address errors.

github-actions[bot] commented 10 months ago

Newest code from emdecr has been published to preview environment for Git SHA 6aa0043a9216ad44ca96a75c04895148021a1fd1

github-actions[bot] commented 10 months ago

Newest code from emdecr has been published to preview environment for Git SHA ce4a28b0b7cdc60fcbd0e271fad3a179c8336dc0

github-actions[bot] commented 10 months ago

Newest code from emdecr has been published to preview environment for Git SHA ad24ca41c35ac577cc725d5bb82b1b74a28884f3

github-actions[bot] commented 10 months ago

Newest code from emdecr has been published to preview environment for Git SHA 9a809cda519ec4fd6501deab9f5aa07421fe6359

github-actions[bot] commented 10 months ago

Newest code from emdecr has been published to preview environment for Git SHA 9e60be607b4f1ec95374d342221782539d582e6e

emdecr commented 10 months ago

Oh whoa – that was a doozy. Thanks to @azigler for helping me debug while on our sync 😂

For breadcrumb purposes: Something to note is that whatever is looking at this specific template is super strict on formatting. Feels like things get encoded differently. Does not like spaces, white space, html comments, and the partials that would normally work on any other page throw errors 🙃 .

I think we're okay now 🤞

Edit: I just saw my inbox – apologies for the pings haha

github-actions[bot] commented 10 months ago

Newest code from emdecr has been published to preview environment for Git SHA 7cbae5fb830aef70136c7f68c192a4e71206179c

cwarnermm commented 10 months ago

@emdecr - Please feel free to merge this in whenever you're ready.