search

mattermost / mattermost-developer-documentation

Mattermost developer documentation.
https://developers.mattermost.com
BSD 3-Clause "New" or "Revised" License
80 stars 389 forks source link

Fix indentation for correct building of tips section #1316

Closed harsh4723 closed 9 months ago

harsh4723 commented 9 months ago

The tip component in https://developers.mattermost.com/contribute/why-contribute/#you-want-to-help-with-content was not rendering the hyperlink properly. After going through the .md file, it has incorrect indentation, so it was unable to build properly. Fixed the indentation and tested locally. Current view Screenshot 2023-12-01 at 11 22 22 PM

Corrected view Screenshot 2023-12-01 at 11 22 36 PM

mattermost-build commented 9 months ago

Hello @harsh4723,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement? Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

harsh4723 commented 9 months ago

/check-cla

github-actions[bot] commented 9 months ago

Newest code from cwarnermm has been published to preview environment for Git SHA 0b437a2643d91f250eab1e157b7bccf48497f650

github-actions[bot] commented 9 months ago

Newest code from cwarnermm has been published to preview environment for Git SHA 0b437a2643d91f250eab1e157b7bccf48497f650

harsh4723 commented 9 months ago

Hi @cwarnermm, In local it is working properly the preview is as expected. About the build failure. It is happening in my local also, in the master branch also. It is caused by html-validate package which In turn is using a library that is recently being updated. Here is the issue for that - https://github.com/ext/better-ajv-errors/issues/151

cwarnermm commented 9 months ago

Thank you, @harsh4723! Great investigation. I'm not surprised to hear that a dependency needed to build the site needs to be updated. We'll investigate further and once resolved, we'll be able to merge in your docs PR.

harsh4723 commented 9 months ago

Sure @cwarnermm, until the issue in the library https://github.com/ext/better-ajv-errors is resolved, we can address the current problem by explicitly specifying the previous version 2.1.0 of the "@sidvind/better-ajv-errors" package in project's package.json file. I can raise a PR if needed.

cwarnermm commented 9 months ago

Thank you, @harsh4723! I'd welcome that PR from you.

harsh4723 commented 9 months ago

The library issue is fixed now https://github.com/ext/better-ajv-errors/releases/tag/v2.1.2 @cwarnermm can you please retrigger the builds it should work now.

github-actions[bot] commented 9 months ago

Newest code from cwarnermm has been published to preview environment for Git SHA 0b437a2643d91f250eab1e157b7bccf48497f650