search

mattermost / mattermost-developer-documentation

Mattermost developer documentation.
https://developers.mattermost.com
BSD 3-Clause "New" or "Revised" License
80 stars 389 forks source link

[GH-1281] OpenSSL Compatibility: Add -legacy option #1332

Closed Omar8345 closed 7 months ago

Omar8345 commented 7 months ago

Summary

This pull request fixes a OpenSSL command in the Install the Mattermost push notification service documentation, which extracts the private key from a certificate, by adding the -legacy option, this is due to since OpenSSL 3.0, the RC2 algorithm has been moved to the legacy provider, which is not loaded by default.

Ticket Link

Fixes https://github.com/mattermost/mattermost-developer-documentation/issues/1281

mattermost-build commented 7 months ago

Hello @Omar8345,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

esarafianou commented 7 months ago

This issue stems out of the fact that Apple’s .p12 files use older encryption standards including TripleDES-CBC and RC2. Although I don't like suggesting our customers to use legacy algorithms and flags, there's probably no other option before Apple updates they encryption standards for .p12 files. But before I approve this, I'd like @jupenur's input if there's any better alternative

Omar8345 commented 7 months ago

@cwarnermm The code review I bet it's done, you can just approve the review, well, nothing is there to be reviewed by you except capitalizing the first letter in the word Apple (company).