mattermost / mattermost-developer-documentation

Mattermost developer documentation.
https://developers.mattermost.com
BSD 3-Clause "New" or "Revised" License
79 stars 383 forks source link

IS-6653: Personal access token docs have outdated screenshots #1357

Closed Rutam21 closed 2 months ago

Rutam21 commented 2 months ago

Summary

Personal Access Token page has outdated product screenshots which can be very confusing to the users. This PR adds the updated screenshots that align with the latest product and also includes additional screenshots in other sections that missed the visual references.

Ticket Link

This PR fixes https://github.com/mattermost/docs/issues/6653.

Checklist

mattermost-build commented 2 months ago

Hello @Rutam21,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Rutam21 commented 2 months ago

@cwarnermm Please review and suggest changes, if any. Thanks.

github-actions[bot] commented 2 months ago

Newest code from cwarnermm has been published to preview environment for Git SHA bb9b10ce39ce75dd72a7719393555eea679668cc

cwarnermm commented 2 months ago

This is a great update, @Rutam21! Thank you!

I'm probably being over-cautious, but I recommend that you hide additional details in the Manage Personal Tokens screenshot. I can almost make out your email address (which you likely don't want visible at all), and I also recommend blurring out some or all of the Token ID.

Rutam21 commented 2 months ago

@cwarnermm Thanks for the suggestion. I have blurred those details to the maximum extent and updated the screenshot. Also, for safety reasons, I deleted that token after raising the PR.

cwarnermm commented 2 months ago

@amyblais - Looking for a second approval to merge. Thanks!

amyblais commented 2 months ago

@cwarnermm Approved!