search

mattermost / mattermost-developer-documentation

Mattermost developer documentation.
https://developers.mattermost.com
BSD 3-Clause "New" or "Revised" License
80 stars 401 forks source link

Remove excess `<br>` #1375

Closed ckaznable closed 5 months ago

ckaznable commented 5 months ago

Summary

I found extra <br>characters in document

mattermost-build commented 5 months ago

Hello @ckaznable,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement? Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

ckaznable commented 5 months ago

/check-cla

cwarnermm commented 5 months ago

@enahum - Please confirm that <br> should be removed in these specific instances.

ckaznable commented 5 months ago

I can find these variables without <br> in these codes

https://github.com/mattermost/mattermost-mobile/blob/main/fastlane/env_vars_example#L39

https://github.com/mattermost/mattermost-mobile/blob/main/fastlane/env_vars_example#L62

https://github.com/mattermost/mattermost-mobile/blob/main/fastlane/Fastfile#L104

https://github.com/mattermost/mattermost-mobile/blob/main/fastlane/.env.ios.release#L19

enahum commented 5 months ago

I can find these variables without <br> in these codes

https://github.com/mattermost/mattermost-mobile/blob/main/fastlane/env_vars_example#L39

https://github.com/mattermost/mattermost-mobile/blob/main/fastlane/env_vars_example#L62

https://github.com/mattermost/mattermost-mobile/blob/main/fastlane/Fastfile#L104

https://github.com/mattermost/mattermost-mobile/blob/main/fastlane/.env.ios.release#L19

There is a difference in how they are shown in the documentation for reading purposes,
in the webpage was suppoused to create a new line and not show the actual
string in the name of the environment variable but it seems that is no longer the case.

Will approve the PR