mattermost / mattermost-developer-documentation

Mattermost developer documentation.
https://developers.mattermost.com
BSD 3-Clause "New" or "Revised" License
79 stars 383 forks source link

Instruction for stopping docker container is given in developing Mattermost without docker documentation #1378

Closed chessmadridista closed 1 month ago

chessmadridista commented 1 month ago

What is the issue?

In the section titled "Develop Mattermost without Docker" on this link, the code for stopping docker container is given.

If we are developing Mattermost without Docker, is there any need for that code snippet?

Proposed solution

The stop-server make target does not stop all the docker containers started by run-server. To stop the running docker containers:

make stop-docker

This whole section can be removed for better readability.

chessmadridista commented 1 month ago

I would be happy to take up this issue if it is something that needs to be resolved.

cwarnermm commented 1 month ago

Thank you, @chessmadridista!

chessmadridista commented 1 month ago

Hi @cwarnermm, PR related to this issue is #1380.