Replaces node-fetch v2 (sync-fetch) with node-fetch v3

[tnir]

• Follows up #1098

Summary

This change replaces sync-fetch with await and node-fetch@3.3.2 as sync-fetch does not support node-fetch v3 and allow us to avoid whatwg-url@5.0.0. node-fetch@3.3.2 does NOT depend on any version of whatwg-url.

Ticket Link

n/a

Why

node-fetch 2.x, followed by sync-fetch, does not support Node.js 21 and higher fully as it relies on punycode depending from whatwg-url 5.0.0.

• cf. https://github.com/mattermost/mattermost/pull/27463 (fixing the same problem in the main repo)
• See also https://github.com/larsgw/sync-fetch/issues/29

As is, with Node.js 21+, we can see warning as follows due to dependency to whatwg-url@5.0.0:

$ make plugin-data                
mkdir -p site/data
go run ./cmd/plugin-godocs > site/data/PluginGoDocs.json
go run ./cmd/plugin-manifest-docs > site/data/PluginManifestDocs.json
[...]
rm -rf scripts/mattermost-webapp || true
cd scripts && npm install

up to date, audited 45 packages in 535ms

[...]

mkdir -p site/data
node scripts/plugin-jsdocs.js > site/data/PluginJSDocs.json
(node:48006) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
(node:48005) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)

Refs.

• See #1098 for why and when node-fetch was introduced into the repo.

[mattermost-build]

Hello @tnir,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

[M-ZubairAhmed]

@tnir you mentioned we can avoid whatwg-ur but what is the reasoning behind avoiding it?

[tnir]

@M-ZubairAhmed Thanks. I just added some explanation to the description. Thoughts?

[M-ZubairAhmed]

/update-branch

[M-ZubairAhmed]

@tnir Thank you for the explanation this makes sense to me

[tnir]

@M-ZubairAhmed Thanks. With your update the branch, it looks like being ready for merging to me.

[M-ZubairAhmed]

@M-ZubairAhmed Thanks. With your update the branch, it looks like being ready for merging to me.

Yes sure, lets ask @cwarnermm for a lookup

[github-actions[bot]]

Newest code from cwarnermm has been published to preview environment for Git SHA 73a47a2ce0ee0289622ab46be5e0791b8db6bdf5