mattermost / mattermost-developer-documentation

Mattermost developer documentation.
https://developers.mattermost.com
BSD 3-Clause "New" or "Revised" License
80 stars 401 forks source link

Update _index.md #1399

Closed jlandells closed 1 week ago

jlandells commented 2 months ago

Added more detail to when a bot is allowed to upload a file to a channel

Summary

Ticket Link

github-actions[bot] commented 2 months ago

Newest code from jlandells has been published to preview environment for Git SHA e39fa0c79eac866535cc55698eb37c8d3ac31d5b

github-actions[bot] commented 2 months ago

Newest code from cwarnermm has been published to preview environment for Git SHA d26b14d8365a09d797399ba5c0f38f059dc21ae2

jlandells commented 1 week ago

Too much back and forth for such a minor change. Will leave it as is and let the customers figure it out. 😞

hanzei commented 1 week ago

I don't understand why you closed the PR. This is an improvement, and we should merge it. As I pointed out in https://github.com/mattermost/mattermost-developer-documentation/pull/1399#discussion_r1796639861, we can make the docs even clearer, but that can be a follow-up.

jlandells commented 1 week ago

I get it, but whilst this has sat open and we've been discussing it, it got out of sync and I'd have had to do additional work to add a simple note that there seemed to be contention around. It felt better to just let the docs be cleaned up by someone who understands this better than I do.

github-actions[bot] commented 1 week ago

Newest code from mattermost has been published to preview environment for Git SHA d26b14d8365a09d797399ba5c0f38f059dc21ae2

github-actions[bot] commented 1 week ago

Newest code from mattermost has been published to preview environment for Git SHA 4d499846fca23d03cf7652378e7c2152935dad30

github-actions[bot] commented 1 week ago

Newest code from mattermost has been published to preview environment for Git SHA 4d499846fca23d03cf7652378e7c2152935dad30

hanzei commented 1 week ago

I'm happy to bring the PR over the finish line. CI is green. Would you mind if I merge your change @jlandells ?

jlandells commented 1 week ago

Would you mind if I merge your change @jlandells ?

Go for it! 😎