search

mattermost / mattermost-docker

Deprecated
Apache License 2.0
963 stars 575 forks source link

move docker-compose file to an example folder #507

Closed tbpoetke closed 3 years ago

tbpoetke commented 3 years ago

Summary

to prevent docker-compose file got overwritten with every pull

mattermod commented 3 years ago

Hello @Aschenbecher,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement? Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

angeloskyratzakos commented 3 years ago

/check-cla

mattermod commented 3 years ago

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

/cc @jasonblais @jfrerich @emilyacook

mattermod commented 3 years ago

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

/cc @jasonblais @jfrerich @emilyacook

jfrerich commented 3 years ago

@angeloskyratzakos and @stylianosrigas, gentle ping for reviews

tbpoetke commented 3 years ago

Hey,

sorry for the late reply. To be honest, I didnt put much afford into this PR, I was just annoyed, that with every pull the docker compose is overwritten. We had this discussion about this topic already one year ago. There was a maintainer who was very committed to changing this. But somehow at some point someone changed it back, and now again, the docker compose file is overwritten all the time and I have to make a backup and write it back. It's just a small thing, but it's annoying and the fix is so easy, because of a lot of other repositorys are doing it like this: put the docker-compose files into an examples folder. The only problem is the build step, because the build files have to be relative to the docker-compose files, i didn't found a better solution then to copy the example to the root. Maybe someone else will find a better solution, so maybe you should see this PR more like a suggestion ;)

jaydeland commented 3 years ago

Why is this file in a jwilder subdirectory? examples/jwilder/docker-compose.yml

I am guessing that this should be renamed to server.

tbpoetke commented 3 years ago

@jaydeland Jwilder is a popular reverse proxy. Maybe someone else will add a compose file for traeffik in another folder.

mattermod commented 3 years ago

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

/cc @jasonblais @jfrerich @emilyacook

emilyacook commented 3 years ago

@Aschenbecher thank you so much for this PR! Would you be open to signing the CLA? It's the last step before we can merge :)

cpanato commented 3 years ago

this repository is no longer maintained see: https://github.com/mattermost/mattermost-docker#readme

we made a new place for docker related https://github.com/mattermost/docker

closing this PR, thanks for your contribution