Closed RenePinnow closed 2 years ago
Hello @RenePinnow,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla
and confirm that the CLA check is green.
This is a standard procedure for many open source projects.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.
/check-cla
@RenePinnow thanks for the PR can you update it and fix the conflict?
@cpanato Conflicts are solved.
Thanks for participating in Hacktoberfest! You can claim your sticker set here: https://get.printfection.com/hacktober21/4144583267 @RenePinnow
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
/cc @jasonblais @jfrerich @emilyacook
@cpanato Why was this never merged?
@cpanato Why was this never merged?
there is a conflict that needs to be addressed
@cpanato I updated my fork again on the newest version. Can you please check and merge. I would like to update mattermost chart and would be nice if it is gitops ready.
there is a lint issue
charts/mattermost-enterprise-edition/Chart.yaml
40:47 error no new line character at the end of file (new-line-at-end-of-file)
also can you squash the commits?
@cpanato Squashed my commits and fixed the issue.
thanks @RenePinnow for the PR
I will redirect to @spirosoik and @stylianosrigas for review and to sync the merges
@RenePinnow looks good to me thanks a lot
@spirosoik can you please merge it?
Summary
give the option to overwrite random string from configmap else applications like argocd will infinity sync because there always a diff
give the option to provide secrets from external because storing secret data like passwords in git is an anti pattern.
remove replicas if ha is enabled. The number of replicas is calculate by hpa else there is a diff between git and the cluster state.
Ticket Link
Fixes https://github.com/mattermost/mattermost-helm/issues/261