mattermost / mattermost-helm

Mattermost Helm charts for Kubernetes
Apache License 2.0
165 stars 148 forks source link

update chart to be GitOps ready #268

Closed RenePinnow closed 2 years ago

RenePinnow commented 2 years ago

Summary

Ticket Link

Fixes https://github.com/mattermost/mattermost-helm/issues/261

mattermod commented 2 years ago

Hello @RenePinnow,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement? Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

RenePinnow commented 2 years ago

/check-cla

cpanato commented 2 years ago

@RenePinnow thanks for the PR can you update it and fix the conflict?

RenePinnow commented 2 years ago

@cpanato Conflicts are solved.

emilyacook commented 2 years ago

Thanks for participating in Hacktoberfest! You can claim your sticker set here: https://get.printfection.com/hacktober21/4144583267 @RenePinnow

mattermod commented 2 years ago

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

/cc @jasonblais @jfrerich @emilyacook

RenePinnow commented 2 years ago

@cpanato Why was this never merged?

cpanato commented 2 years ago

@cpanato Why was this never merged?

there is a conflict that needs to be addressed

RenePinnow commented 2 years ago

@cpanato I updated my fork again on the newest version. Can you please check and merge. I would like to update mattermost chart and would be nice if it is gitops ready.

cpanato commented 2 years ago

there is a lint issue

charts/mattermost-enterprise-edition/Chart.yaml
  40:47     error    no new line character at the end of file  (new-line-at-end-of-file)

also can you squash the commits?

RenePinnow commented 2 years ago

@cpanato Squashed my commits and fixed the issue.

cpanato commented 2 years ago

thanks @RenePinnow for the PR

I will redirect to @spirosoik and @stylianosrigas for review and to sync the merges

spirosoik commented 2 years ago

@RenePinnow looks good to me thanks a lot

RenePinnow commented 2 years ago

@spirosoik can you please merge it?